Cast genome count to string in macs2 wrapper#430
Open
Conversation
One extra space still persists after the genome_count value in the macs2 command. Unsure how to remove it. It does not produce an error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user defines
effective_genome_countin config.yaml as2E7, for example, the value will be read in as a string and there will be no Python concatenation error. However, if the user enters an integer value such as2056938195into config.yaml as theeffective_genome_count, the value will be read in as an integer and Python will error: can't concatenate int with str.Even if we remove this wrapper script in future versions of lcdbwf, if this line persists elsewhere, it should be updated to force the effective_genome_count value from config.yaml into str for concatenation.